Skip to content

Commit

Permalink
Update/remove certain todo doco
Browse files Browse the repository at this point in the history
  • Loading branch information
JamesDPC committed Feb 5, 2018
1 parent d9e736b commit 9451383
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 6 deletions.
3 changes: 1 addition & 2 deletions src/connector/Event.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ class Event extends Base {
* @param string $begin an RFC 2822 formatted UTC datetime OR empty string for no begin datetime
* @param string $event_filter see https://documentation.mailgun.com/en/latest/api-events.html#event-types can also be a filter expression e.g "failed OR rejected"
* @param boolean $resubmit whether to resubmit events if possible
* @todo when two installs share the same api_domain, events will be synchronised to both install.
* Possible workaround is to tag each message with a specific install 'tag' and add this as a filter on event polling here
* @todo when two installs share the same api_domain, events will be synchronised to both install. Possible workaround is to tag each message with a specific install 'tag' and add this as a filter on event polling here
*/
public function pollEvents($begin = NULL, $event_filter = "", $resubmit = false, $extra_params = array()) {

Expand Down
1 change: 0 additions & 1 deletion src/connector/Message.php
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,6 @@ public function storeTestMessage(\MailgunEvent $event) {

/**
* Given an Event, store its contents if it is > 2 days old and if config allows
* @todo encryption of downloaded message ?
* @param \MailgunEvent $event
* @param string $contents
* @param boolean $force
Expand Down
2 changes: 0 additions & 2 deletions src/mailer/Mailer.php
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ public function setSender($email, $name = "") {

/**
* Send a message using the Mailgun messages API. If there is a submission source, save the resulting message.id on successful response
* @TODO once a message is sent, clear tags and submission? Leave test mode as-is?
* @param string $to
* @param string $from
* @param string $subject
Expand Down Expand Up @@ -167,7 +166,6 @@ final protected function saveResponse($message) {
}

/**
* TODO parse out any X- prefixed headers and add them as h:X-My-Header
* TODO support all o:options in Mailgun API
*/
protected function addCustomParameters(&$parameters, $headers) {
Expand Down
1 change: 0 additions & 1 deletion src/models/MailgunEvent.php
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,6 @@ public static function StoreEvent(MailgunEventModel $event, $mailgun_message_id

/**
* Provide action buttons to allow a resubmit. Only failures marked 'permanent' can be resubmitted - temporary failures are retried by MG
* TODO permission check for button and resubmit() access
*/
public function getCMSActions() {
$actions = parent::getCMSActions();
Expand Down

0 comments on commit 9451383

Please sign in to comment.