Fix some warnings and replace deprecated items #131
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MR is build on top of #130.
This fixes some warnings that have popped up in the new Flutter version.
There are some problematic areas:
textScaleFactor
is deprecated in favour oftextScaler
to support non-linear scaling:Except for a few instances I did not do anything with this warning, because it is not a simple replacement. We rely on the the textscale factor in some places for layout. Replacing the factor with the text-scaler will require us to provide the font size of the text that we are trying to account for. I left this for a future merge request.
ColorScheme
background
andonBackground
are deprecated in favour ofsurface
andonSurface
. Unfortunately we were already using different colors forsurface
andonSurface
, butbackground
was the same color assecondaryContainer
, so I addedonSecondaryContainer
with the oldonBackground
color and used that throughout the app.