Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cyrillic letters to sort tests #161

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Add cyrillic letters to sort tests #161

merged 2 commits into from
Oct 18, 2024

Conversation

nt4f04uNd
Copy link
Owner

@nt4f04uNd nt4f04uNd commented Oct 18, 2024 •
edited
Loading

Fixes #158

@nt4f04uNd nt4f04uNd requested a review from Abestanis October 18, 2024 21:38
Abestanis
Abestanis approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@Abestanis Abestanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small nit about the newline. Thanks for adding the tests.

.gitignore Outdated Show resolved Hide resolved
test/logic/models/sort_test.dart
songWith(id: 5, dateModified: 0, dateAdded: 0, title: 'A', artist: '', album: ''),
songWith(id: 7, dateModified: 0, dateAdded: 0, title: 'a', artist: '', album: ''),
songWith(id: 6, dateModified: 0, dateAdded: 0, title: 'AA', artist: '', album: ''),
songWith(id: 8, dateModified: 0, dateAdded: 0, title: 'z', artist: '', album: ''),
songWith(id: 17, dateModified: 0, dateAdded: 0, title: 'А (кириллица)', artist: '', album: ''),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I thought that it's weird that this entry is is sorted after the z, but it looks like it's standard behaviour that all cyrillic letters are sorted after the ascii ones.

@nt4f04uNd @Abestanis
Update .gitignore
604f781 
Co-authored-by: Abestanis <abestanis.gc@gmail.com>
@nt4f04uNd
Copy link
Owner Author

Thanks for adding the tests.

Thanks for making them =)

@Abestanis
Copy link
Collaborator

I've seen this CI failure before, but I can't replicate it locally. My guess is that we start the initialization in a test, and then the test ends but the while the initialization is waiting on an await point and we start a new test overwriting the queue controller. For now I think you can just re-run the test, but a real solution it to either find a way to cancel / await all un-awaited futures started or to not have singletons and instead pass in all controllers when creating the app.

@nt4f04uNd nt4f04uNd mentioned this pull request Oct 18, 2024
Open
@nt4f04uNd nt4f04uNd merged commit a3015cd into master Oct 18, 2024
4 checks passed
@nt4f04uNd
Copy link
Owner Author

Created an issue #162

@nt4f04uNd nt4f04uNd deleted the cyrillic-sort-test branch October 18, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abestanis Abestanis Abestanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto test cyrillic sorting
2 participants
@nt4f04uNd @Abestanis