Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use controller definition configmap from user namespace #518

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chandankumar4
Copy link
Contributor

Fixes #429

Modifications

  • Update rolloutConfig map for storing [namespace/version] as key with fullSpec as value
  • While reading the data from rolloutConfig firstly check user specific namespace configmap if not found then use from "numaplane-system" namespace

Verification

  • Verified on local kubernetes cluster by creating configmap in user namesapce

Backward incompatibilities

@chandankumar4
Copy link
Contributor Author

Unit test is pending to add!!

Signed-off-by: chandankumar4 <chandan.kr404@gmail.com>
@chandankumar4 chandankumar4 force-pushed the numaflow-controller-def branch from b639e91 to c055065 Compare January 22, 2025 23:36
@chandankumar4 chandankumar4 added the enhancement New feature or request label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capability for user namespace-specific Controller definitions
1 participant