feat: perform child healthiness assessment over a period of time #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t within a time window multiple times. Signed-off-by: Antonino Fugazzotto <antonino_fugazzotto@intuit.com>
Signed-off-by: Antonino Fugazzotto <antonino_fugazzotto@intuit.com>
Signed-off-by: Antonino Fugazzotto <antonino_fugazzotto@intuit.com>
…tiness assessments Signed-off-by: Antonino Fugazzotto <antonino_fugazzotto@intuit.com>
Signed-off-by: Antonino Fugazzotto <antonino_fugazzotto@intuit.com>
Signed-off-by: Antonino Fugazzotto <antonino_fugazzotto@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #520
Modifications
Added a config parameter to describe the assessment schedule via 3 numerical values: a time delay when to start the assessment, for how long to perform assessments, and how often to assess within the assessment window.
Modified the assessment logic and requeuing logic to reflect the 3 values above based on assessment result. The assessment will stop in case of failure unless a new upgrade version of the rollout is being reconciled.
Verification
Manual tests, E2e tests, and unit tests.
Backward incompatibilities
No issue.