Remove reinforcement learning notebook from executable build #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a quick ping @melissawm as I think the dependency anchor from the RL tutorial is really impacting stability here. I've tried to do this in the simplest way I could think of with minimal impact with an eye for a more general discussion to follow, but if you (or anyone else) would prefer a different approach please LMK! |
|
Look good to me @rossbar - following the conversation at the Documentation team meeting today, let's follow up with ideas about how to deal with non-executable content. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted elsewhere the
atari-pypackage on which the reinforcement learning tutorial was based was deprecated (#87), and the project that replaces it EULA(s) that need to be reviewed and may no longer be suitable for open source.We had been using the deprecated
atari-py, but this has many problems, including the requirement of building wheels locally, and now dependency issues (see #143).Given all this, I think it's past time that we remove these dependencies, which will necessitate switching the RL notebook to no longer be executable. I took the simplest possible approach to this in this PR. Ultimately, I'd like to start a discussion about what to do with content that is not executable, but I'll leave that for another issue/meeting.