[CS2103T-T11-2] Dukemon #102
Open
+29,397
−5,426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambhinav
reviewed
Oct 3, 2019
|
|
||
| |`* * *` |user |see the content of the word bank |study beforehand/make changes | ||
|
|
||
| |`* * *` |young student |trivia questions to be gamified |enjoy the process |
There was a problem hiding this comment.
Perhaps you should write a more specific benefit instead of "enjoy the process"
ambhinav
reviewed
Oct 3, 2019
|
|
||
| |`* * *` |user |delete word banks |free up some memory when I don’t need it anymore | ||
|
|
||
| |`* * *` |user |see the content of the word bank |study beforehand/make changes |
There was a problem hiding this comment.
May need to rephrase this use case. Can't really understand how the benefit relates to the "I want to..."
ambhinav
reviewed
Oct 3, 2019
|
|
||
| |`* *` |studious student |set and complete goals |have something to work towards | ||
|
|
||
| |`* *` |student |see my test statistics |track my progress/improvement |
ambhinav
reviewed
Oct 3, 2019
docs/DeveloperGuide.adoc
Outdated
| . A user with above average typing speed for regular English text (i.e. not code, not system admin commands) should be able to accomplish most of the tasks faster using commands than using the mouse. | ||
| . Users can export and import their <<word-bank,word banks>> or statistics. |
ambhinav
reviewed
Oct 3, 2019
|
|
||
| |`* *` |student |share and compare my results with my classmates |know where I stand | ||
|
|
||
| |`* *` |student |partition the trivia |attempt questions that I'm comfortable with |
There was a problem hiding this comment.
Consider rephrasing "partition the trivia" to "sort according to difficulty" etc..
ambhinav
reviewed
Oct 3, 2019
elsakoh
reviewed
Oct 24, 2019
| Holds the data of live game sessions in-memory. | ||
| * <<Design-Storage,*`Storage`*>>: + | ||
| Reads data from, and writes data to, the local hard disk. | ||
|
|
There was a problem hiding this comment.
Good introduction to your main components, easy to understand.
elsakoh
reviewed
Oct 24, 2019
| @@ -12,7 +12,7 @@ ifdef::env-github[] | |||
| :note-caption: :information_source: | |||
| :warning-caption: :warning: | |||
| endif::[] | |||
| :repoURL: https://github.com/se-edu/addressbook-level3/tree/master | |||
| :repoURL: https://github.com/AY1920S1-CS2103T-T11-2/main | |||
elsakoh
reviewed
Oct 24, 2019
docs/DeveloperGuide.adoc
Outdated
|
|
||
| image::UndoRedoState1.png[] | ||
|
|
||
| Step 3. The user executes `add n/David ...` to add a new person. The `add` command also calls `Model#commitAddressBook()`, causing another modified address book state to be saved into the `addressBookStateList`. | ||
| Step 3. The user executes `stop` to abruptly end the game. The `add` command also calls `Model#commitAddressBook()`, causing another modified address book state to be saved into the `addressBookStateList`. |
| @@ -131,6 +150,20 @@ As a more OOP model, we can store a `Tag` list in `Address Book`, which `Person` | |||
| + | |||
| image:BetterModelClassDiagram.png[] | |||
|
|
|||
| [[Design-Game]] | |||
| === Game component | |||
|
|
|||
| Class HiddenOutside #FFFFFF | ||
| HiddenOutside ..> Game | ||
| HiddenOutside ..> Guess | ||
| Game -- ReadOnlyWordBank :.clone() Cards from > |
There was a problem hiding this comment.
i do not think the .clone() should be in the UML diagram
docs/DeveloperGuide.adoc
Outdated
|
|
||
| image::UndoRedoState0.png[] | ||
|
|
||
| Step 2. The user executes `delete 5` command to delete the 5th person in the address book. The `delete` command calls `Model#commitAddressBook()`, causing the modified state of the address book after the `delete 5` command executes to be saved in the `addressBookStateList`, and the `currentStatePointer` is shifted to the newly inserted address book state. | ||
| Step 2. The user enters `start difficult` command to begin the game. The `LogicManager` passes string to `Model#commitAddressBook()`, causing the modified state of the address book after the `delete 5` command executes to be saved in the `addressBookStateList`, and the `currentStatePointer` is shifted to the newly inserted address book state. | ||
|
|
||
| image::UndoRedoState1.png[] |
There was a problem hiding this comment.
The diagrams do not fit the descriptions.
|
|
||
|
|
||
| .Structure of the Game Component | ||
| image::GameClassDiagram.png[] |
There was a problem hiding this comment.
A method should not be indicated in the association label
added more pictures and cleaned up the bullet pointing
Updated UG - Command Summary
… into chenhui-2-codeQuality # Conflicts: # docs/UserGuide.adoc
…lity Chenhui 2 code quality
Upon start, sample data will be automatically created, but will not automatically create itself again after it has been removed by user.
… into chenhui-2-codeQuality
… into subbash-29-finalCodeUpdate
…odeUpdate Update Use cases
… into jason-2-ppp
Update PPP and some tests
… into chenhui-3-UGDG
Chenhui 3 ugdg
Italicise some words
… into subbash-29-finalCodeUpdate
Subbash 29 final code update
Added Page Breaks for UG
Final formatting edits for DG
… into chenhui-3-UGDG
Chenhui 3 ugdg
Fix PPP adoc and pdf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kohyida1997 @chrischenhui @dragontho @jascxx