Fix spell and type annotation issue

nuxeo · Jun 17, 2024 · 661f6bf · 661f6bf
1 parent 9c157c2
commit 661f6bf
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/nxdrive/client/workflow/__init__.py b/nxdrive/client/workflow/__init__.py
@@ -14,7 +14,7 @@
 class Workflow:
     """Workflow Management for document Review"""
 
-    user_task_list = {}
+    user_task_list: Dict[str, List[str]] = {}
 
     def __init__(self, remote: "Remote") -> None:
         self.remote = remote

diff --git a/nxdrive/manager.py b/nxdrive/manager.py
@@ -944,7 +944,7 @@ def unbind_engine(self, uid: str, /, *, purge: bool = False) -> None:
             return
 
         if Feature.tasks_management:
-            # Clean user tasks data incase we are unbinding the account.
+            # Clean user tasks data in case we are unbinding the account.
             self.workflow = Workflow(engine.remote)
             self.workflow.clean_user_task_data(engine.remote.user_id)
 

diff --git a/tests/unit/test_workflow.py b/tests/unit/test_workflow.py
@@ -95,7 +95,7 @@ def test_get_pending_task_for_single_doc(workflow, engine, task, remote):
     engine.remote = remote
     engine.remote.tasks.get = Mock(return_value=[task])
     workflow.fetch_document = Mock()
-    assert workflow.get_pending_tasks(engine, False) is None
+    assert workflow.get_pending_tasks(engine) is None
     assert Workflow.user_task_list == {"user_a": ["taskid_test"]}
 
 
@@ -109,12 +109,12 @@ def test_get_pending_task_for_multiple_doc(workflow, engine, task, remote):
     engine.remote = remote
     engine.remote.tasks.get = Mock(return_value=[task1, task2])
     engine.send_task_notification = Mock()
-    assert workflow.get_pending_tasks(engine, False) is None
+    assert workflow.get_pending_tasks(engine) is None
     assert Workflow.user_task_list == {"user_a": ["taskid_2", "taskid_2"]}
 
     # user_task_list[a_user] have [tasks_a, tasks_b] and got tasks[tasks_a, tasks_b].
     # In this case no need to the send notification
-    assert workflow.get_pending_tasks(engine, False) is None
+    assert workflow.get_pending_tasks(engine) is None
     assert Workflow.user_task_list == {"user_a": ["taskid_2", "taskid_2"]}
 
 
@@ -124,11 +124,11 @@ def test_remove_overdue_tasks(workflow, engine, task, remote):
     task.dueDate = datetime_1_hr_ago.strftime("%Y-%m-%dT%H:%M:%S.%f%z")
     engine.remote.tasks.get = Mock(return_value=[task])
     engine.send_task_notification = Mock()
-    assert workflow.get_pending_tasks(engine, False) is None
+    assert workflow.get_pending_tasks(engine) is None
 
     # raise exception
     task.dueDate = None
-    assert workflow.get_pending_tasks(engine, False) is None
+    assert workflow.get_pending_tasks(engine) is None
 
 
 def test_fetch_document(workflow, engine, task):