Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2882: fix_db should create dump.sql in same dir as db (Sourcery refactored) #4473

Conversation

sourcery-ai[bot]
Copy link
Contributor

@sourcery-ai sourcery-ai bot commented Jan 9, 2024

Pull Request #4472 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the wip-NXDRIVE-2882-fix_db-should-create-dump.sql-in-same-dir-as-db branch, then run:

git fetch origin sourcery/wip-NXDRIVE-2882-fix_db-should-create-dump.sql-in-same-dir-as-db
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from gitofanindya January 9, 2024 07:37
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Sourcery AI seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (945b187) 49.02% compared to head (9824738) 49.01%.

Additional details and impacted files
@@                                         Coverage Diff                                          @@
##           wip-NXDRIVE-2882-fix_db-should-create-dump.sql-in-same-dir-as-db    #4473      +/-   ##
====================================================================================================
- Coverage                                                             49.02%   49.01%   -0.01%     
====================================================================================================
  Files                                                                    94       94              
  Lines                                                                 15683    15683              
====================================================================================================
- Hits                                                                   7688     7687       -1     
- Misses                                                                 7995     7996       +1     
Flag Coverage Δ
functional 37.93% <100.00%> (ø)
unit 37.48% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sourcery-ai sourcery-ai bot force-pushed the sourcery/wip-NXDRIVE-2882-fix_db-should-create-dump.sql-in-same-dir-as-db branch 3 times, most recently from 0a80663 to 48e06b8 Compare January 12, 2024 06:45
@sourcery-ai sourcery-ai bot force-pushed the sourcery/wip-NXDRIVE-2882-fix_db-should-create-dump.sql-in-same-dir-as-db branch from 48e06b8 to 9824738 Compare January 16, 2024 04:28
return bool(status[0] == "ok")
return status[0] == "ok"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function is_healthy refactored with the following changes:

@sourcery-ai sourcery-ai bot closed this Jan 16, 2024
@sourcery-ai sourcery-ai bot deleted the sourcery/wip-NXDRIVE-2882-fix_db-should-create-dump.sql-in-same-dir-as-db branch January 16, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant