-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NXDRIVE-2901: Authorization Error for OAuth #4616
NXDRIVE-2901: Authorization Error for OAuth #4616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Type: Enhancement
PR Summary: The pull request aims to address an authorization error in the OAuth flow within the NXDrive application. It modifies the OAuth2 initialization process by ensuring the 'verify' parameter is correctly set in the 'subclient_kwargs'. This change is intended to enhance the robustness and reliability of the OAuth authorization process.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Ensure that the modification does not introduce any side effects in the OAuth flow, especially in environments with different security requirements.
- Review the naming and initialization pattern of 'subclient_kwargs' to ensure it aligns with the project's coding standards and practices.
- Consider the impact of this change on existing deployments and whether any additional configuration or documentation updates are needed to support the change.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4616 +/- ##
==========================================
+ Coverage 49.17% 49.25% +0.07%
==========================================
Files 94 94
Lines 15681 15699 +18
==========================================
+ Hits 7711 7732 +21
+ Misses 7970 7967 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
45c86c6
to
c3974aa
Compare
c3974aa
to
c2026ad
Compare
8e81903
to
55f2d97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.