Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2901: Authorization Error for OAuth #4616

Merged
merged 9 commits into from
Apr 3, 2024

Conversation

gitofanindya
Copy link
Collaborator

No description provided.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: The pull request aims to address an authorization error in the OAuth flow within the NXDrive application. It modifies the OAuth2 initialization process by ensuring the 'verify' parameter is correctly set in the 'subclient_kwargs'. This change is intended to enhance the robustness and reliability of the OAuth authorization process.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.

General suggestions:

  • Ensure that the modification does not introduce any side effects in the OAuth flow, especially in environments with different security requirements.
  • Review the naming and initialization pattern of 'subclient_kwargs' to ensure it aligns with the project's coding standards and practices.
  • Consider the impact of this change on existing deployments and whether any additional configuration or documentation updates are needed to support the change.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

nxdrive/auth/oauth2.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.25%. Comparing base (81d7886) to head (fb14740).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4616      +/-   ##
==========================================
+ Coverage   49.17%   49.25%   +0.07%     
==========================================
  Files          94       94              
  Lines       15681    15699      +18     
==========================================
+ Hits         7711     7732      +21     
+ Misses       7970     7967       -3     
Flag Coverage Δ
functional 38.08% <100.00%> (+0.07%) ⬆️
integration 2.06% <0.00%> (-0.01%) ⬇️
unit 37.57% <17.39%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nxdrive/auth/oauth2.py Outdated Show resolved Hide resolved
@gitofanindya gitofanindya force-pushed the wip-NXDRIVE-2901-Authorization-Error-for-OAuth branch 7 times, most recently from 45c86c6 to c3974aa Compare February 29, 2024 05:44
@gitofanindya gitofanindya force-pushed the wip-NXDRIVE-2901-Authorization-Error-for-OAuth branch from c3974aa to c2026ad Compare February 29, 2024 06:10
@gitofanindya gitofanindya force-pushed the wip-NXDRIVE-2901-Authorization-Error-for-OAuth branch from 8e81903 to 55f2d97 Compare March 26, 2024 05:41
@gitofanindya gitofanindya requested a review from mr-shekhar April 2, 2024 06:03
Copy link
Collaborator

@mr-shekhar mr-shekhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tests/functional/test_oauth2.py Show resolved Hide resolved
@gitofanindya gitofanindya merged commit 74fc14e into master Apr 3, 2024
25 checks passed
@gitofanindya gitofanindya deleted the wip-NXDRIVE-2901-Authorization-Error-for-OAuth branch April 3, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants