Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(InputMenu): removing tag does not change modelValue #3054

Merged
merged 8 commits into from
Jan 9, 2025

Conversation

rdjanuar
Copy link
Collaborator

@rdjanuar rdjanuar commented Jan 9, 2025

πŸ”— Linked issue

Resolves #2743

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Screenshot 2025-01-09 at 14 59 25

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

pkg-pr-new bot commented Jan 9, 2025

npm i https://pkg.pr.new/@nuxt/ui@3054

commit: bffae79

@benjamincanac
Copy link
Member

I think this might solve #2743, wdyt @rdjanuar?

@rdjanuar
Copy link
Collaborator Author

rdjanuar commented Jan 9, 2025

I think it's a different issue.

In the reproduction video, although InputMenu doesn't use the multiple prop, they expect that clicking the same value should uncheck it.

Do you think this is a bug or is this the intended behavior? @benjamincanac

Edit:

I apologize - I missed watching the other video. Yes, it solves that issue, but it doesn't address the other issue I mentioned @benjamincanac

@benjamincanac
Copy link
Member

I guess this is the intended behavior or at least 1:1 with Reka UI: https://reka-ui.com/docs/components/combobox

@benjamincanac benjamincanac merged commit 5a44394 into nuxt:v3 Jan 9, 2025
2 of 4 checks passed
@benjamincanac
Copy link
Member

Thanks @rdjanuar 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UInputMenu not triggering when remove items in multiple mode
2 participants