fix(Form): standard schema validation no longer wrapped in value object

[Gerbuuun]

🔗 Linked issue

Not an issue, but it was noticed in this PR: #2880

❓ Type of change

• 📖 Documentation (updates to the documentation or readme)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality)
• ✨ New feature (a non-breaking change that adds functionality)
• 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The standard schema validation implementation wrapped the state in an object with value as key:

const result = await schema['~standard'].validate({
  value: state,
})

The wrapped object is now also part of the object to be validated. This means all error messages also have value added to their path and breaks it. I highly suspect this is an artifact left behind from copying the valibot validator from UI2?

Anyways, in the standard-schema repo the example does not show to wrap the input data.

New implementation:

const result = await schema['~standard'].validate(state)

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[pkg-pr-new]

npm i https://pkg.pr.new/@nuxt/ui@3104

commit: 174fcc3

[Gerbuuun]

Ok, the standard-schema example does show getting the data by result.value. Also typescript is saying that. But this PR fixes the problem anyways? I'm a bit confused. Looking into it furter

[OhB00]

Using safeParser (https://valibot.dev/api/safeParser/) is a workaround, but I feel like you shouldn't need to do this.

[sandros94]

Using safeParser (https://valibot.dev/api/safeParser/) is a workaround, but I feel like you shouldn't need to do this.

Indeed, since at that point you are effectively using Valibot instead of standard-schema

[Gerbuuun]

So both actually "work" but let's just follow the spec and only return the value from the validation result (otherwise there is the extra value field). @fabian-hiller any reason why Valibot returns the validated data in result and in result.value?

edit: I moved up the isStandardSchema check function to test this bug but forgot to put it back. I'd argue that we should put at the top anyways as more libraries are going to adopt standard schema.

[fabian-hiller]

Quick clarification. We probably implemented Standard Schema in Nuxt UI before we changed a few things. Initially, Standard Schema required an object to be passed to its validate function with a key called value. We have simplified this API so that the value can be passed directly. If the latest Standard Schema spec is supported, any Valibot (and soon Zod and co.) specific code can probably be removed. I can offer to try to review this PR in the next few days.

The Standard Schema spec README is up-to-date and can be followed when implementing the spec.

[fabian-hiller]

I have reviewed the changes and they look good to me. Thanks for fixing it and supporting the spec! Happy to answer any questions about the spec and Valibot.

[romhml]

Thanks @Gerbuuun! Should we also remove valibot specific examples? Or at least the safeParser wrapper from the valibot example?

https://github.com/nuxt/ui/blob/v3/docs/app/components/content/examples/form/FormExampleValibot.vue#L25

[Gerbuuun]

I think all valibot specific code/examples can be replaced by ones for standard-schema. Should I include them in this PR?

[romhml]

As you want, we can also handle it in a new one!