Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: packages cleanup #34

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Soap-141
Copy link
Contributor

@Soap-141 Soap-141 commented Jun 3, 2024

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe: Cleanup

Description

  • Update packages.
  • Fix the iOS Artifact name.

Impact on version

  • Major
    • The template structure was changed.
  • Minor
    • New functionalities were added.
  • Patch
    • A bug in behavior was fixed.
    • Documentation was changed.

PR Checklist

Always applicable

No matter your changes, these checks always apply.

  • Your conventional commits are aligned with the Impact on version section.
  • Updated CHANGELOG.md.
    • Use the latest Major.Minor.X header if you do a Patch change.
    • Create a new Major.Minor.X header if you do a Minor or Major change.
    • If you create a new header, it aligns with the Impact on version section and matches what is generated in the build pipeline.
  • Documentation files were updated according with the changes.
    • Update README.md and src/cli/CLI.md if you made changes to templating.
    • Update AzurePipelines.md and src/app/README.md if you made changes to pipelines.
    • Update Diagnostics.md if you made changes to diagnostic tools.
    • Update Architecture.md and its diagrams if you made architecture decisions or if you introduced new recipes.
    • ...and so forth: Make sure you update the documentation files associated to the recipes you changed. Review the topics by looking at the content of the doc/ folder.
  • Images about the template are referenced from the wiki and added as images in this git.
  • TODO comments are hints for next steps for users of the template and not planned work.

Contextual

Based on your changes these checks may not apply.

  • Automated tests for the changes have been added/updated.
  • Tested on all relevant platforms

Other information

Internal Issue (If applicable):

@Soap-141 Soap-141 closed this Jun 3, 2024
@Soap-141 Soap-141 force-pushed the dev/thla/chore-package-cleanup branch from a6eb81d to 4186ab6 Compare June 3, 2024 22:10
@Soap-141 Soap-141 reopened this Jun 4, 2024
Copy link

mergify bot commented Jun 4, 2024

⚠️ The sha of the head commit of this PR conflicts with #33. Mergify cannot evaluate rules on this PR. ⚠️

@Soap-141 Soap-141 force-pushed the dev/thla/chore-package-cleanup branch 2 times, most recently from d1e0678 to 679251e Compare June 4, 2024 19:17
@Soap-141 Soap-141 marked this pull request as ready for review June 4, 2024 19:17
@Soap-141 Soap-141 force-pushed the dev/thla/chore-package-cleanup branch from 679251e to 07ca241 Compare June 4, 2024 19:19
src/cli/CHANGELOG.md Show resolved Hide resolved
@Soap-141 Soap-141 force-pushed the dev/thla/chore-package-cleanup branch from 2607fbd to 4858250 Compare June 4, 2024 19:35
@Soap-141 Soap-141 requested a review from jeanplevesque June 4, 2024 19:36
@Soap-141 Soap-141 force-pushed the dev/thla/chore-package-cleanup branch from 6c3308e to a8291bf Compare June 4, 2024 20:19
@Soap-141 Soap-141 force-pushed the dev/thla/chore-package-cleanup branch from c118b8e to 34c5d2c Compare June 5, 2024 14:08
@Soap-141 Soap-141 force-pushed the dev/thla/chore-package-cleanup branch 2 times, most recently from 790e0e7 to fb3b098 Compare June 19, 2024 13:07
src/app/pubspec.yaml Outdated Show resolved Hide resolved
@Soap-141 Soap-141 force-pushed the dev/thla/chore-package-cleanup branch from 9202a79 to fbffc29 Compare June 19, 2024 13:36
@Soap-141 Soap-141 changed the title chore: Package version cleanup Fix CI/CD and packages cleanup Jun 19, 2024
@Soap-141 Soap-141 force-pushed the dev/thla/chore-package-cleanup branch 3 times, most recently from 17e6bed to eac643d Compare June 19, 2024 14:36
@Soap-141
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Soap-141 Soap-141 force-pushed the dev/thla/chore-package-cleanup branch from e21333b to 831b345 Compare June 19, 2024 18:36
@Soap-141 Soap-141 force-pushed the dev/thla/chore-package-cleanup branch from 7f839d1 to 4cc6028 Compare June 19, 2024 18:43
@Soap-141 Soap-141 changed the title Fix CI/CD and packages cleanup chore: packages cleanup Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants