Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add tinted-vim support to base16 theme #1352

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ducklin5
Copy link

if vim.g.base16_gui00 and vim.g.base16_gui0F then

base16-vim is now tinted-vim and the variable names have changed from g:base16_gui00 to g:tinted_gui00
The above line in the base16 theme would need an or g:tinted_gui00 to add support for the new names without breaking older versions

@ducklin5 ducklin5 changed the title fix: add titned-vim support to base16 theme fix: add tinted-vim support to base16 theme Dec 28, 2024
@phantomwhale
Copy link

Thanks for submitting this @ducklin5 - was just updating my configuration to match the base16-vim -> tinted-vim rename, and stumbled over this issue too. Hopefully this can get merged soon, to remove the Lualines warning I'm seeing now on boot

@ducklin5
Copy link
Author

ducklin5 commented Jan 3, 2025

Thanks!
Hopefully one of the maintainers can have a look at this. @shadmansaleh
Also looks like there is now a duplicate PR: #1357

@ducklin5
Copy link
Author

ducklin5 commented Jan 4, 2025

Looks like there was a PR before mine even: #1346

@JamyGolden
Copy link
Contributor

I've just merged a PR into tinted-vim which adds the legacy vim.g.base16_gui0X variables back. So while we're waiting for the maintainers here to merge the changes, things should be working if you use the latest tinted-vim: tinted-theming/tinted-vim#100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants