Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtins/diagnostics: add pydoclint #181

Merged
merged 8 commits into from
Jan 17, 2025
Merged

Conversation

aemonge
Copy link
Contributor

@aemonge aemonge commented Sep 12, 2024

Supporting extended python doc string documentation lint with https://jsh9.github.io/pydoclint/

@mochaaP
Copy link
Member

mochaaP commented Sep 13, 2024

Waiting for upstream.

@aemonge aemonge marked this pull request as ready for review September 13, 2024 07:05
@aemonge
Copy link
Contributor Author

aemonge commented Sep 13, 2024

I've also generated documentation on the pydoclint repo-> jsh9/pydoclint#167

@barrett-ruth
Copy link
Collaborator

@aemonge I believe this is ready for you to address final comments. Thanks for the contribution!

@aemonge
Copy link
Contributor Author

aemonge commented Jan 15, 2025

Thank you so much for the patience, I've updated the code with the suggestions.

@mochaaP
Copy link
Member

mochaaP commented Jan 15, 2025

Is the null_pydoclint check still needed? I could not find any results of this on github: https://github.com/search?q=null_pydoclint&type=code

@mochaaP mochaaP changed the title Create pydoclint.lua builtins/diagnostics: add pydoclint Jan 15, 2025
@aemonge
Copy link
Contributor Author

aemonge commented Jan 15, 2025

@mochaaP you're right, I had an alias for null_pydoclint, but ended up removing it. Nice catch!

Thanks

@mochaaP
Copy link
Member

mochaaP commented Jan 15, 2025

all severities are currently mapped to "warning". do we still need the mapping table?

@aemonge
Copy link
Contributor Author

aemonge commented Jan 15, 2025

I think we do, at least to show all available serveries.

@mochaaP
Copy link
Member

mochaaP commented Jan 15, 2025

Can you test the updated branch?

@aemonge
Copy link
Contributor Author

aemonge commented Jan 17, 2025

Just did, working :)

@mochaaP mochaaP merged commit b93e44d into nvimtools:main Jan 17, 2025
3 checks passed
@mochaaP
Copy link
Member

mochaaP commented Jan 17, 2025

thank you. 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants