Skip to content

Commit

Permalink
[MD settings] fix tooltips on policy icons
Browse files Browse the repository at this point in the history
This CL changes the relative position for tooltips vs the trigger for
the tooltip so that the tooltip shows up reliably.

Bug: 774046
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I78f8fd6b95992a2c4e3f1a1d7b1ff43a969a4654
Reviewed-on: https://chromium-review.googlesource.com/719581
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509188}(cherry picked from commit 5f88902)
Reviewed-on: https://chromium-review.googlesource.com/726400
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#56}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
  • Loading branch information
dschuyler committed Oct 18, 2017
1 parent f47ffe1 commit 0dda3c3
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion chrome/browser/resources/settings/search_settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ cr.define('settings', function() {
// Dynamically position the bubble at the edge the associated control
// element.
var updatePosition = function() {
searchBubble.style.top =
searchBubble.style.top = element.offsetTop +
(innards.classList.contains('above') ? -searchBubble.offsetHeight :
element.offsetHeight) +
'px';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
min-height: var(--cr-section-min-height);
outline: none;
padding: 0 var(--cr-section-padding);
position: relative;
}

:host([disabled]) {
Expand Down
1 change: 0 additions & 1 deletion ui/webui/resources/cr_elements/shared_vars_css.html
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@
display: flex;
min-height: var(--cr-section-min-height);
padding: 0 var(--cr-section-padding);
position: relative;
};

--cr-title-text: {
Expand Down

0 comments on commit 0dda3c3

Please sign in to comment.