Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify firebase-tools version for ci cd #184

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Specify firebase-tools version for ci cd #184

merged 2 commits into from
Dec 15, 2023

Conversation

meleongg
Copy link
Member

Description

  • fixes CI/CD after breaking firebase-tools change

Other considerations

@meleongg meleongg requested a review from DonaldKLee December 14, 2023 02:19
Copy link

Visit the preview URL for this PR (updated for commit 198fd63):

https://nwplus-io--pr184-fix-ci-cd-h6kwtz5p.web.app

(expires Thu, 21 Dec 2023 02:22:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a778397fecec2eb8f19e28d7b9fa723113d13f3d

Copy link
Member

@DonaldKLee DonaldKLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DonaldKLee DonaldKLee merged commit 7be2c78 into main Dec 15, 2023
2 checks passed
@meleongg meleongg deleted the fix-ci-cd branch December 15, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants