Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix controlled closing of websockets #110

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Fix controlled closing of websockets #110

merged 2 commits into from
Jan 15, 2024

Conversation

rowanseymour
Copy link
Member

Addresses #109

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (6fc7181) 89.72% compared to head (6daeb9a) 90.16%.

Files Patch % Lines
httpx/websocket.go 85.71% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   89.72%   90.16%   +0.43%     
==========================================
  Files          39       39              
  Lines        1859     1891      +32     
==========================================
+ Hits         1668     1705      +37     
+ Misses        153      150       -3     
+ Partials       38       36       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour rowanseymour merged commit 20e83c1 into main Jan 15, 2024
6 of 7 checks passed
@rowanseymour rowanseymour deleted the websocket_closing branch January 15, 2024 21:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant