Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CWService interface and MockCWService for testing #148

Closed
wants to merge 2 commits into from

Conversation

norkans7
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 88.28%. Comparing base (c430b1e) to head (112a0bc).

Files with missing lines Patch % Lines
aws/cwatch/mock/mock.go 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   89.13%   88.28%   -0.86%     
==========================================
  Files          50       51       +1     
  Lines        2218     2236      +18     
==========================================
- Hits         1977     1974       -3     
- Misses        186      206      +20     
- Partials       55       56       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@norkans7 norkans7 force-pushed the add-cw-service-interface branch from aca3595 to f660897 Compare December 13, 2024 10:25
@norkans7 norkans7 force-pushed the add-cw-service-interface branch from b7ec4ab to 69cdba3 Compare December 13, 2024 11:14
@norkans7 norkans7 changed the title Add CWService interface Add CWService interface and MockCWService for testing Dec 13, 2024
@norkans7 norkans7 force-pushed the add-cw-service-interface branch from 69cdba3 to 50605cb Compare December 13, 2024 11:21
@norkans7 norkans7 force-pushed the add-cw-service-interface branch from 30b1b04 to 112a0bc Compare December 13, 2024 11:33
@norkans7 norkans7 marked this pull request as ready for review December 13, 2024 11:39
@rowanseymour
Copy link
Member

Closing in favor of #149

@rowanseymour rowanseymour deleted the add-cw-service-interface branch December 13, 2024 16:26
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants