For dev deployments, cloudwatch service should just log to console #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Dec 13, 2024
aws/cwatch/client.go
Outdated
| for _, dim := range md.Dimensions { | ||
| log = log.With(strings.ToLower(aws.ToString(dim.Name)), aws.ToString(dim.Value)) | ||
| } | ||
| log.With("metric", aws.ToString(md.MetricName), "value", aws.ToFloat64(md.Value)).Info("put metric data") |
There was a problem hiding this comment.
2024/12/13 11:03:02 INFO put metric data namespace=Foo deployment=dev metric=NumGoats value=10
2024/12/13 11:03:02 INFO put metric data namespace=Foo deployment=dev host=foo1 metric=NumSheep value=20
2024/12/13 11:03:02 INFO put metric data namespace=Foo deployment=dev metric=NumFish value=30
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
=======================================
Coverage 89.13% 89.14%
=======================================
Files 50 51 +1
Lines 2218 2238 +20
=======================================
+ Hits 1977 1995 +18
Misses 186 186
- Partials 55 57 +2 ☔ View full report in Codecov by Sentry. |
rowanseymour
force-pushed
the
cloudwatch_dev
branch
from
625af7d to
bbb3bdc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.