Skip to content

Commit

Permalink
update to metadata v8.9.13, remove must dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
nicpottier committed Sep 7, 2018
1 parent 75ce226 commit 5590087
Show file tree
Hide file tree
Showing 4 changed files with 38 additions and 34 deletions.
2 changes: 1 addition & 1 deletion metadata_bin.go

Large diffs are not rendered by default.

10 changes: 7 additions & 3 deletions phonenumbers_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (
"testing"

"github.com/golang/protobuf/proto"
"github.com/theothertomelliott/go-must"
)

func TestParse(t *testing.T) {
Expand Down Expand Up @@ -1261,13 +1260,18 @@ func TestRegexCacheStrict(t *testing.T) {
NationalNumber: proto.Uint64(4130203445),
}
firstRunResult := Format(phoneToTest, NATIONAL)
must.BeEqual(t, expectedResult, firstRunResult, "phone number formatting not as expected")
if expectedResult != firstRunResult {
t.Errorf("phone number formatting not as expected")
}
// This adds value to the regex cache that would break the following lookup if the regex-s
// in cache were not strict.
Format(&PhoneNumber{
CountryCode: proto.Int32(973),
NationalNumber: proto.Uint64(17112724),
}, NATIONAL)
secondRunResult := Format(phoneToTest, NATIONAL)
must.BeEqual(t, expectedResult, secondRunResult, "phone number formatting not as expected")

if expectedResult != secondRunResult {
t.Errorf("phone number formatting not as expected")
}
}
6 changes: 3 additions & 3 deletions prefix_to_carriers_bin.go

Large diffs are not rendered by default.

54 changes: 27 additions & 27 deletions prefix_to_geocodings_bin.go

Large diffs are not rendered by default.

0 comments on commit 5590087

Please sign in to comment.