Update locations 1 #5775
Update locations 1 #5775
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5775 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 446 448 +2
Lines 25133 25165 +32
=========================================
+ Hits 25133 25165 +32 ☔ View full report in Codecov by Sentry. |
norkans7
force-pushed
the
update-locations-1
branch
4 times, most recently
from
27384fa to
c735b2b
Compare
temba/locations/models.py
Outdated
| geometries = GeometryManager() | ||
|
|
||
| class Meta: | ||
| indexes = [models.Index(Upper("name"), name="locations_by_name")] |
There was a problem hiding this comment.
If we keep it, let's switch to Lower("name") instead as most other models use lower instead of upper.
temba/locations/models.py
Outdated
| level = models.IntegerField() | ||
| parent = TreeForeignKey("self", null=True, on_delete=models.PROTECT, related_name="children", db_index=True) | ||
| path = models.CharField(max_length=768) # e.g. Rwanda > Kigali | ||
| simplified_geometry = models.JSONField(null=True) |
There was a problem hiding this comment.
Did we used to store two types of geometry? One simplified and one not?
There was a problem hiding this comment.
I think so as that is how the extraction is done with posm
There was a problem hiding this comment.
Or that was just to match the simplified_geometry field we get from the extraction
temba/locations/models.py
Outdated
| name = models.CharField(max_length=Location.MAX_NAME_LEN, help_text="The name for our alias") | ||
|
|
||
| class Meta: | ||
| indexes = [models.Index(Upper("name"), name="locationaliases_by_name")] |
temba/locations/models.py
Outdated
| simplified_geometry = models.JSONField(null=True) | ||
|
|
||
| objects = NoGeometryManager() | ||
| geometries = GeometryManager() |
There was a problem hiding this comment.
this doesn't feel worth having
norkans7
force-pushed
the
update-locations-1
branch
from
c735b2b to
7940785
Compare
norkans7
force-pushed
the
update-locations-1
branch
from
e0d8038 to
e54497c
Compare
No description provided.