Deps poetry #5789
Deps poetry #5789
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5789 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 448 448
Lines 25142 25142
=========================================
Hits 25142 25142 ☔ View full report in Codecov by Sentry. |
norkans7
force-pushed
the
deps-poetry
branch
2 times, most recently
from
be08db5 to
7957136
Compare
| @@ -15,7 +15,7 @@ def datetime_to_str(date_obj, format, tz): | |||
| if not date_obj: | |||
| return None | |||
|
|
|||
| if type(date_obj) == date: | |||
There was a problem hiding this comment.
Fix ruff check
E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
pyproject.toml
Outdated
| @@ -7,53 +7,54 @@ authors = [ | |||
| ] | |||
| readme = "README.md" | |||
| requires-python = ">=3.12,<3.13" | |||
| dependencies = [] | |||
| dependencies = [ | |||
| "django (>=5.1.4,<5.2.0)", | |||
There was a problem hiding this comment.
can't this be written like ~=5.1.4 ?
pyproject.toml
Outdated
| "django-timezone-field (>=6.1.0,<6.2.0)", | ||
| "djangorestframework (>=3.15.1,<3.16.0)", | ||
| "dj-database-url (>=0.5.0,<0.6.0)", | ||
| "smartmin (==5.1.1)", |
There was a problem hiding this comment.
I get that you didn't change this but it's odd that this one dependency is absolute
There was a problem hiding this comment.
I guess it's because it was added with poetry add? Maybe for all of these they should be tweaked afterwards to allow patch updates.
pyproject.toml
Outdated
| "chardet ~= 4.0.0", | ||
| "openpyxl ~= 3.1.5", | ||
| "ffmpeg-python ~= 0.2.0", | ||
| "slack-sdk (==3.17.0)", |
There was a problem hiding this comment.
any reason why this is different?
I tried to make sure the deps stay to the one we have before this change as much as possible