Test against Elastic 7.x and 8.x and OpenSearch 1.x #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
force-pushed
the
test_es_versions
branch
5 times, most recently
from
f6e4bb2 to
ea9ae11
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
+ Coverage 50.96% 53.77% +2.81%
==========================================
Files 6 6
Lines 569 569
==========================================
+ Hits 290 306 +16
+ Misses 254 238 -16
Partials 25 25 ☔ View full report in Codecov by Sentry. |
rowanseymour
force-pushed
the
test_es_versions
branch
from
ea9ae11 to
b5c323e
Compare
rowanseymour
force-pushed
the
test_es_versions
branch
4 times, most recently
from
ca06c68 to
40c4f35
Compare
rowanseymour
force-pushed
the
test_es_versions
branch
from
40c4f35 to
15872d6
Compare
rowanseymour
commented
May 13, 2024
indexers/base.go
Outdated
|
|
||
| // deletes a document | ||
| const deleteCommand = `{ "delete" : { "_id": %d, "_type": "_doc", "version": %d, "version_type": "external", "routing": %d} }` |
There was a problem hiding this comment.
Note to self: need to check if removing this still works against indexes created with type
rowanseymour
force-pushed
the
test_es_versions
branch
from
6cab68b to
4382ff1
Compare
rowanseymour
force-pushed
the
test_es_versions
branch
from
4382ff1 to
a619adc
Compare
rowanseymour
changed the title
rowanseymour
force-pushed
the
test_es_versions
branch
2 times, most recently
from
19de6ed to
d0bd433
Compare
rowanseymour
force-pushed
the
test_es_versions
branch
from
d0bd433 to
38b36e6
Compare
rowanseymour
commented
May 14, 2024
| @@ -6,6 +6,12 @@ jobs: | |||
| test: | |||
| name: Test | |||
| runs-on: ubuntu-latest | |||
| container: | |||
| image: node:18 | |||
There was a problem hiding this comment.
this makes the test run in a container.. which then has access to the services using their name as the host, e.g. http://elastic7:9200
rowanseymour
force-pushed
the
test_es_versions
branch
from
6d47d57 to
e0085e4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.