Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose tabs #378

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Compose tabs #378

merged 2 commits into from
Oct 30, 2023

Conversation

ericnewcomer
Copy link
Member

For broadcasts:
Screenshot 2023-10-27 at 5 39 34 PM
Screenshot 2023-10-27 at 4 44 13 PM

For contact chat / tickets:
Screenshot 2023-10-27 at 4 41 11 PM

The other variations aren't used anywhere and should probably be removed for simplicity.

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #378 (682f747) into main (b64d4cc) will decrease coverage by 0.23%.
The diff coverage is 83.85%.

@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
- Coverage   79.48%   79.25%   -0.23%     
==========================================
  Files          70       71       +1     
  Lines       19011    19380     +369     
  Branches      647      656       +9     
==========================================
+ Hits        15110    15360     +250     
- Misses       3895     4014     +119     
  Partials        6        6              
Files Coverage Δ
src/RapidElement.ts 73.09% <100.00%> (+1.51%) ⬆️
src/contacts/ContactChat.ts 86.68% <100.00%> (-0.05%) ⬇️
src/interfaces.ts 100.00% <100.00%> (ø)
src/select/Select.ts 85.31% <100.00%> (ø)
src/tabpane/Tab.ts 100.00% <100.00%> (+4.91%) ⬆️
src/textinput/TextInput.ts 83.00% <100.00%> (+0.03%) ⬆️
src/vectoricon/index.ts 100.00% <100.00%> (ø)
temba-modules.ts 100.00% <100.00%> (ø)
src/lightbox/Lightbox.ts 90.96% <0.00%> (-0.56%) ⬇️
src/utils/index.ts 58.34% <37.50%> (-1.90%) ⬇️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericnewcomer ericnewcomer merged commit 6fe4929 into main Oct 30, 2023
@ericnewcomer ericnewcomer deleted the compose-tabs branch October 30, 2023 16:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant