Skip to content

Commit

Permalink
remove default aria-label from share buttons
Browse files Browse the repository at this point in the history
  • Loading branch information
nygardk committed Nov 18, 2023
1 parent 17a3d7d commit 043faa3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/fair-maps-thank.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"react-share": major
---

Removed default `aria-label` prop from `ShareButtons`. Before it defaulted to the name of the "network name" (e.g. "facebook" for Facebook). Issue explained [here](https://github.com/nygardk/react-share/issues/397).
1 change: 0 additions & 1 deletion src/ShareButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ export default function ShareButton<LinkOptions extends Record<string, unknown>>
return (
<button
{...rest}
aria-label={rest['aria-label'] || networkName}
className={newClassName}
onClick={handleClick}
ref={forwardedRef}
Expand Down

0 comments on commit 043faa3

Please sign in to comment.