Added prop to open up a new tab instead of a new window #342
+18
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there any chance to see that pull request being integrated quickly please ? |
|
Please merge soon |
|
@nygardk Please look and merge it asap, if you are looking for a good contributor, I am ready to help. |
|
any chance to get this merged soon? |
|
Is there a chance of getting the PR merged? I really need it |
|
two years now :( |
|
can we merge it pls? :3 |
|
Is there any update here? |
|
Has anyone found a workaround until the PR merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it was annoying that clicking the share button opened a new window so I added a prop that only opens up a new tab on click.