-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Social Share Button and Icon for Bluesky #549
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: ab9d383 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hey, thanks for the addition! Can you add a changeset, as requested by the changeset-bot? |
@nygardk I added the changeset. I made this commit a minor change. Please let me know if you think otherwise. Thanks! |
@nygardk anything else I can do to make the PR ready? |
Pull request awaits, |
Please merge this. Thanks |
We could also use this feature, please consider reviewing it. |
Hi @nygardk! Could you let us know if there are any plans to review and potentially merge this PR? If not, or if there’s no timeline, it would still be great to know so we can explore other solutions. Thank you! |
Hello @nygardk Thank you for a great lib! :-) I need to add bluesky to my project. Getting this PR merged would be a great way to do this :-) Could we get a ball-park estimate as to when this will be merged? Thanks again :-) |
Docs for how share redirect works: https://docs.bsky.app/docs/advanced-guides/intent-links
Noticed there wasn't an option for Bluesky. I retrieved the SVG for the Bluesky logo from the official press kit. Although I scaled down the SVG to be smaller and I centered it like the other SVGs in the package. The blue color I used for the background is the same blue provided in one of the SVG. I used #201 as a basis for this PR.
Here's what this looks like in the demo:
Please let me know if you have any questions/concerns.