-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPE and purl regex #711
CPE and purl regex #711
Conversation
- addresses parts of oasis-tcs#693, oasis-tcs#710 - correct pattern to `^((CPE2.3)|(CPE2.2))$` - add additional `\\` to escape previously unescaped `/`
- addresses parts of oasis-tcs#693 - correct parsing of CPE 2.3 Dictionary (to also capture endings `">` instead of just `"/>`)
- addresses parts of oasis-tcs#693 - add new local test cases - adopt test script
- addresses parts of oasis-tcs#710 - add additional `\\` to escape previously unescaped `/`
@ctron Please review |
- addresses parts of oasis-tcs#693 - add conversion rule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for incorporating these and for following up on the other PR.
Since this is correcting a bug, there is no need to bring it into voting. I will merge the PR now. |
bc6c0f4
into
oasis-tcs:editor-revision-2024-03-27
^((CPE2.3)|(CPE2.2))$
\\
to escape previously unescaped/
(for CPE and purl)">
instead of just"/>
)