Remediation categories #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- addresses parts of oasis-tcs#563 - add value "optional_patch" - adapt prose
- addresses parts of oasis-tcs#563 - add conversion rule for CVRF - add conversion rule from CSAF 2.0
- addresses parts of oasis-tcs#662 - add value `fix_planned` as remediation category - adapt prose - restructure mutually exclusive categories
- addresses parts of oasis-tcs#662 - add conversion rule from CVRF - add conversion rule from CSAF 2.0 - fix format mistake
- addresses parts of oasis-tcs#541, oasis-tcs#662, oasis-tcs#563 - clarify that reference of products can be direct or indirect
- addresses parts of oasis-tcs#541, oasis-tcs#662, oasis-tcs#563 - add mandatory test for contradicting remediations - add invalid examples - add valid examples
- addresses parts of oasis-tcs#541, oasis-tcs#662, oasis-tcs#563 - remove duplicate notes about mutually exclusive categories - add table for contradicting product status group remediation category combinations
- addresses parts of oasis-tcs#541, oasis-tcs#662, oasis-tcs#563 - add mandatory test for contradicting Product status remediations combinations - add invalid examples - add valid examples
- addresses parts of oasis-tcs#541, oasis-tcs#662, oasis-tcs#563 - fix spelling mistake - improve wording - clarify that this also applies to indirect relationships through product groups
- addresses parts of oasis-tcs#541, oasis-tcs#662, oasis-tcs#563 - add optional test for discouraged product status remediation combinations - add invalid examples - add valid examples
- addresses parts of oasis-tcs#541, oasis-tcs#662, oasis-tcs#563 - correct example - add valid example - add invalid example
tschmidtb51
added
editor-revision
Closed
sthagen
reviewed
Oct 25, 2024
| The following tables shows the allowed and prohibited combinations: | ||
|
|
||
| | category value | `workaround` | `mitigation` | `vendor_fix` | `optional_patch` | `none_available` | `fix_planned` | `no_fix_planned` | | ||
| |:----------------:|:------------:|:------------:|:------------:|:----------------:|:----------------:|:-------------:|:----------------:| |
There was a problem hiding this comment.
What about left-aligning the cell values (instead of centering)?
There was a problem hiding this comment.
I guess that is a style thing - what do you prefer?
sthagen
reviewed
Oct 25, 2024
| The following tables shows the allowed, discouraged and prohibited combinations: | ||
|
|
||
| | category value | Affected | Not Affected | Fixed | Under Investigation | Recommended | | ||
| |:----------------:|:----------:|:------------:|:-----------:|:-------------------:|:-----------:| |
There was a problem hiding this comment.
What about left-aligning also here the cell values (instead of centering)?
sthagen
reviewed
Oct 25, 2024
| > A tool MAY apply the conversion rules from the conformance target CSAF 2.0 to CSAF 2.1 converter if applicable or | ||
| > remove the product from the remediation with the lower priority. | ||
| > The priority MAY be defined as follows: | ||
| > `vendor_fix` > `mitigation` > `workaround` > `fix_planned` > `no_fix_planned` > `optional_patch` > `none_available` |
There was a problem hiding this comment.
I am always tempted to right the escaped > for these relation ships, but if a bare greater works 🆗
There was a problem hiding this comment.
vendor_fix>mitigation>workaround>fix_planned>no_fix_planned>optional_patch>none_available
Looks like it does...
sthagen
approved these changes
Oct 25, 2024
...2.1/prose/edit/src/tests-01-mndtr-36-contradicting-product-status-remediation-combination.md
Outdated
Show resolved
Hide resolved
- addresses parts of oasis-tcs#541 - add missing files to bind.txt
- addresses review comments from oasis-tcs#807 - convert unnecessary upper case to lower case
|
LGTM @tschmidtb51. Thank You. |
|
A motion was moved by Thomas to include the changes suggested in this pull request, during the CSAF TC monthly meeting on 2024-10-30. The motion was seconded by Omar. The motion passed. |
santosomar
merged commit 1475f37
into
oasis-tcs:editor-revision-2024-10-30
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add remediation category "fix_planned" #662