Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLP - remove obsolete test #808

Merged
merged 4 commits into from
Oct 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 3 additions & 20 deletions csaf_2.1/prose/edit/src/tests-02-optional.md
Original file line number Diff line number Diff line change
Expand Up @@ -322,27 +322,10 @@ The relevant paths for this test are:

> The hash algorithm `sha1` is used in one item of hashes without being accompanied by a second hash algorithm.

### Missing TLP label (deprecated){#missing-tlp-label}
### Missing TLP label (obsolete){#missing-tlp-label}

It MUST be tested that `/document/distribution/tlp/label` is present and valid.

> TLP labels support the machine-readability and automated distribution.

The relevant path for this test is:

```
/document/distribution/tlp/label
```

*Example 1 (which fails the test):*

```
"distribution": {
"text": "Distribute freely."
}
```

> The CSAF document has no TLP label.
> The TLP label is now required by the schema. Therefore, the optional test is obsolete.
> This section is kept to document that change and keep the numbering of the remaining sections stable.

### Missing Canonical URL

Expand Down

This file was deleted.

10 changes: 0 additions & 10 deletions csaf_2.1/test/validator/data/testcases.json
Original file line number Diff line number Diff line change
Expand Up @@ -1155,16 +1155,6 @@
}
]
},
{
"id": "6.2.10",
"group": "optional",
"failures": [
{
"name": "optional/oasis_csaf_tc-csaf_2_1-2024-6-2-10-01.json",
"valid": true
}
]
},
{
"id": "6.2.11",
"group": "optional",
Expand Down
2 changes: 1 addition & 1 deletion csaf_2.1/test/validator/testcases_json_schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"title": "Number of the test",
"description": "Contains the section number of the test in the specification.",
"type": "string",
"pattern": "^6\\.(([1-3]\\.[1-9])|([12]\\.1[0-9])|(3\\.1[0-2])|([12]\\.2[0-6])|(1\\.2[8-9])|(1\\.27\\.([1-9]|10|11))|(1\\.3[0-4]))$"
"pattern": "^6\\.(([1-3]\\.[1-9])|(1\\.10)|([12]\\.1[1-9])|(3\\.1[0-2])|([12]\\.2[0-6])|(1\\.2[8-9])|(1\\.27\\.([1-9]|10|11))|(1\\.3[0-4]))$"
tschmidtb51 marked this conversation as resolved.
Show resolved Hide resolved
},
"valid": {
"title": "List of valid examples",
Expand Down
Loading