Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date-time #810

Merged
merged 8 commits into from
Oct 30, 2024
Merged

Date-time #810

merged 8 commits into from
Oct 30, 2024

Conversation

tschmidtb51
Copy link
Contributor

@tschmidtb51
Date-time
2c8ed76 
- addresses parts of oasis-tcs#469
- add section on Date and Time to explain the rules
@tschmidtb51 tschmidtb51 added editorial mostly nits and consistency csaf 2.1 csaf 2.1 work labels Oct 25, 2024
@tschmidtb51 tschmidtb51 requested a review from sthagen October 25, 2024 20:10
@tschmidtb51 tschmidtb51 self-assigned this Oct 25, 2024
@tschmidtb51
Copy link
Contributor Author

@sthagen I have a couple questions:

  1. The references for ISO 8601 and RFC 3339 are currently in the informative reference. Should they change to normative?
  2. Should we add test for that?
  3. Do I need to add that file somewhere or does it get picked up automatically?

@tschmidtb51
Date-time
ebf8f28 
- addresses parts of oasis-tcs#469
- specify . as frac-sec separator
- explicitly state no empty timezones
- add reference to ABNF of RFC 3339 section 5.6
@sthagen
Copy link
Contributor

sthagen commented Oct 25, 2024 •
edited
Loading

Now that we want to enforce this, I assume we should move both to normative.
Test cases as regression tests, right? Use and abuse tests that ensure changes to the schema do not change the semantics. Correct? I would like that. Please add the filename to the etc/bind.txt file (where it should be end up during concat)

sthagen
sthagen approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tschmidtb51
Date-time
bf9393b 
- addresses parts of oasis-tcs#469
- move RFC 3339 and ISO 8601 to normative references
@tschmidtb51
Date-time
ec40176 
- addresses parts of oasis-tcs#469
- correct format
- add filename to etc/bind.txt
@tschmidtb51
Date-time
2b508b1 
- addresses parts of oasis-tcs#469
- link section in conformance targets
@tschmidtb51
Copy link
Contributor Author

I'll add the test later (or in a different PR).

sthagen
sthagen approved these changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SLGTM.

tschmidtb51
tschmidtb51 commented Oct 29, 2024
View reviewed changes
Copy link
Contributor Author

@tschmidtb51 tschmidtb51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sthagen: My bad - you were right.

csaf_2.1/prose/edit/src/conformance.md Outdated Show resolved Hide resolved
@sthagen @tschmidtb51
review adjustments
a3b72ba 
Co-authored-by: tschmidtb51 <65305130+tschmidtb51@users.noreply.github.com>
@santosomar
Copy link
Contributor

A motion was moved by Omar to include the changes suggested in this pull request, during the CSAF TC monthly meeting on 2024-10-30. The motion was seconded by Denny. The motion passed.

@santosomar santosomar merged commit 58bc0d5 into oasis-tcs:editor-revision-2024-10-30 Oct 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sthagen sthagen sthagen approved these changes

Assignees

@tschmidtb51 tschmidtb51

Labels
csaf 2.1 csaf 2.1 work editorial mostly nits and consistency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tschmidtb51 @sthagen @santosomar