Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap:label on EntityType and Parameter #102

Merged
merged 6 commits into from
Aug 6, 2024
Merged

Conversation

ralfhandl
Copy link
Contributor

No description provided.

@ralfhandl ralfhandl requested a review from HeikoTheissen August 6, 2024 13:01
Comment on lines +137 to +141
"GetOne": {
"$Function": "V2.Annotations.GetOne"
}
},
"GetOne": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is one <FunctionImport> converted to two properties with the same name, one inside the Container and one outside?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. V4 needs both a function (in the schema) and a function import (in the entity container) to achieve the same effect as a function import in V2.

@ralfhandl ralfhandl merged commit ee1b764 into main Aug 6, 2024
2 checks passed
@ralfhandl ralfhandl deleted the entitytype-sap-label branch August 6, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants