-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: bump actions/upload-artifact from 3 to 4 #1596
ci: bump actions/upload-artifact from 3 to 4 #1596
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1596 +/- ##
==========================================
- Coverage 63.70% 60.41% -3.30%
==========================================
Files 114 139 +25
Lines 8374 9949 +1575
==========================================
+ Hits 5335 6011 +676
- Misses 3039 3896 +857
- Partials 0 42 +42 ☔ View full report in Codecov by Sentry. |
no documented changes, only a note that it makes this action more locked into github's hosted runners. no |
ok after some more research this seems fine. I don't think we ever try to modify artifacts from multiple jobs. and I think we don't use any of this project's artifacts anywhere else, so we're fine there too. let me try a test run that uploads the artifacts (without the if: failure()) to make sure the uploads still work edit: https://github.com/actions/upload-artifact/releases/tag/v4.0.0 had been revised with more info, and there's a migration guide https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md @dependabot rebase |
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
bbda7e0
to
689c120
Compare
✅ Deploy Preview for oasisprotocol-oasis-sdk canceled.
|
Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request |
seems fine. as long as the screenshots don't cause any problems. I think there are no screenshots if the tests pass, so there aren't any uploaded in this test run |
ab13ab4
to
689c120
Compare
@dependabot merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh right I gotta review
release notes sound fine
Bumps actions/upload-artifact from 3 to 4.
Release notes
Sourced from actions/upload-artifact's releases.
Commits
c7d193f
Merge pull request #466 from actions/v4-beta13131bb
licensed cache4a6c273
Merge branch 'main' into v4-betaf391bb9
Merge pull request #465 from actions/robherley/v4-documentation9653d03
Apply suggestions from code review875b630
add limitations sectionecb2146
add compression example5e7604f
trim some repeated infod6437d0
naming1b56155
s/v4-beta/v4/gYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot will merge this PR once CI passes on it, as requested by @pro-wh.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)