Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump actions/upload-artifact from 3 to 4 #1596

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 15, 2023

Bumps actions/upload-artifact from 3 to 4.

Release notes

Sourced from actions/upload-artifact's releases.

v4.0.0

What's Changed

The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements.

For more information, see the @​actions/artifact documentation.

New Contributors

Full Changelog: actions/upload-artifact@v3...v4.0.0

v3.1.3

What's Changed

Full Changelog: actions/upload-artifact@v3...v3.1.3

v3.1.2

  • Update all @actions/* NPM packages to their latest versions- #374
  • Update all dev dependencies to their most recent versions - #375

v3.1.1

  • Update actions/core package to latest version to remove set-output deprecation warning #351

v3.1.0

What's Changed

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @pro-wh.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot requested review from kostko and pro-wh as code owners December 15, 2023 01:25
@dependabot dependabot bot added the c:deps Category: external dependencies label Dec 15, 2023
@dependabot dependabot bot requested a review from ptrus as a code owner December 15, 2023 01:25
@dependabot dependabot bot added the c:testing Category: testing label Dec 15, 2023
@dependabot dependabot bot requested a review from peternose as a code owner December 15, 2023 01:25
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.41%. Comparing base (aaca763) to head (bbda7e0).
Report is 2 commits behind head on main.

❗ Current head bbda7e0 differs from pull request most recent head 689c120. Consider uploading reports for the commit 689c120 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1596      +/-   ##
==========================================
- Coverage   63.70%   60.41%   -3.30%     
==========================================
  Files         114      139      +25     
  Lines        8374     9949    +1575     
==========================================
+ Hits         5335     6011     +676     
- Misses       3039     3896     +857     
- Partials        0       42      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pro-wh
Copy link
Contributor

pro-wh commented Jan 26, 2024

no documented changes, only a note that it makes this action more locked into github's hosted runners. no

@pro-wh
Copy link
Contributor

pro-wh commented Apr 15, 2024

ok after some more research this seems fine. I don't think we ever try to modify artifacts from multiple jobs. and I think we don't use any of this project's artifacts anywhere else, so we're fine there too. let me try a test run that uploads the artifacts (without the if: failure()) to make sure the uploads still work

edit: https://github.com/actions/upload-artifact/releases/tag/v4.0.0 had been revised with more info, and there's a migration guide https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md

@dependabot rebase

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/upload-artifact-4 branch from bbda7e0 to 689c120 Compare April 15, 2024 23:00
Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for oasisprotocol-oasis-sdk canceled.

Name Link
🔨 Latest commit 689c120
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-sdk/deploys/661ebd3722f4c60008201f06

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 15, 2024

Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@pro-wh
Copy link
Contributor

pro-wh commented Apr 16, 2024

seems fine. as long as the screenshots don't cause any problems. I think there are no screenshots if the tests pass, so there aren't any uploaded in this test run

@pro-wh pro-wh force-pushed the dependabot/github_actions/actions/upload-artifact-4 branch from ab13ab4 to 689c120 Compare April 16, 2024 18:02
@pro-wh
Copy link
Contributor

pro-wh commented Apr 16, 2024

@dependabot merge

Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right I gotta review

release notes sound fine

@dependabot dependabot bot merged commit 0e2a592 into main Apr 16, 2024
53 checks passed
@dependabot dependabot bot deleted the dependabot/github_actions/actions/upload-artifact-4 branch April 16, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:deps Category: external dependencies c:testing Category: testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant