Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some documentation to graphql_query/ in trustfall_core #138

Merged
merged 6 commits into from
Feb 11, 2023

Conversation

ginger51011
Copy link
Contributor

As discussed #136, this adds some minor documentation to graphql_query. There are still things to do, but these are the things I am somewhat confident writing about.

@ginger51011
Copy link
Contributor Author

I should have ran the doctests...

Marked as ignore since I don't think it's possible to access the directive structs from doctests without changing their visibility. This means someone should probably check that the examples are actually correct themselves

Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good! Just a few minor polishing suggestions. Thanks for putting this together!

trustfall_core/src/graphql_query/directives.rs Outdated Show resolved Hide resolved
trustfall_core/src/graphql_query/directives.rs Outdated Show resolved Hide resolved
trustfall_core/src/graphql_query/directives.rs Outdated Show resolved Hide resolved
trustfall_core/src/graphql_query/directives.rs Outdated Show resolved Hide resolved
trustfall_core/src/graphql_query/directives.rs Outdated Show resolved Hide resolved
trustfall_core/src/graphql_query/directives.rs Outdated Show resolved Hide resolved
trustfall_core/src/graphql_query/directives.rs Outdated Show resolved Hide resolved
trustfall_core/src/graphql_query/directives.rs Outdated Show resolved Hide resolved
trustfall_core/src/graphql_query/error.rs Outdated Show resolved Hide resolved
trustfall_core/src/graphql_query/mod.rs Outdated Show resolved Hide resolved
ginger51011 and others added 3 commits February 11, 2023 12:12
Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>
Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>
This is what you get for merging on GitHub...
@obi1kenobi obi1kenobi merged commit 83575e6 into obi1kenobi:main Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants