Skip to content

Commit

Permalink
Update hasoneedit.yml config for SS5 and PHP8.2
Browse files Browse the repository at this point in the history
Currently when set to After: framework/* we are getting an error whenever the MAILER_DSN environment variable is set.

Updating this to just After: framework seems to resolve the issue.

Error we were getting was the following - 
		Fatal error: Uncaught MJS\TopSort\CircularDependencyException: Circular dependency found: modelascontrollercatchallroute->hasoneedit->mailer-dsn-env->hasoneedit in /vendor/marcj/topsort/src/CircularDependencyException.php:34 Stack trace: 
		#0 /vendor/marcj/topsort/src/Implementations/BaseImplementation.php(57): MJS\TopSort\CircularDependencyException::create(Array) 
		#1 /vendor/marcj/topsort/src/Implementations/ArraySort.php(63): MJS\TopSort\Implementations\BaseImplementation->throwCircularExceptionIfNeeded(Object(stdClass), Array) 
		stevie-mayhew#2 /vendor/marcj/topsort/src/Implementations/ArraySort.php(75): MJS\TopSort\Implementations\ArraySort->visit(Object(stdClass), Array) 
		stevie-mayhew#3 /vendor/marcj/topsort/src/Implementations/ArraySort.php(75): MJS\TopSort\Implementations\ArraySort->visit(Object(stdClass), Array) 
		stevie-mayhew#4 /vendor/marcj/topsort/src/Implementations/ArraySort.php(75): MJS\TopSort\Implementations\ArraySort->visit(Object(stdClass), Array) 
		stevie-mayhew#5 /vendor/marcj/topsort/src/Implementations/ArraySort.php(115): MJS\TopSort\Implementations\ArraySort->visit(Object(stdClass), Array) 
		stevie-mayhew#6 /vendor/marcj/topsort/src/Implementations/ArraySort.php(98): MJS\TopSort\Implementations\ArraySort->doSort() 
		stevie-mayhew#7 /vendor/silverstripe/config/src/Transformer/YamlTransformer.php(517): MJS\TopSort\Implementations\ArraySort->sort() 
		stevie-mayhew#8 /vendor/silverstripe/config/src/Transformer/YamlTransformer.php(104): SilverStripe\Config\Transformer\YamlTransformer->getSortedYamlDocuments() 
		stevie-mayhew#9 /vendor/silverstripe/config/src/Collections/MemoryConfigCollection.php(73): SilverStripe\Config\Transformer\YamlTransformer->transform(Object(SilverStripe\Config\Collections\MemoryConfigCollection)) 
		stevie-mayhew#10 /vendor/silverstripe/framework/src/Core/Config/CoreConfigFactory.php(89): SilverStripe\Config\Collections\MemoryConfigCollection->transform(Array) 
		stevie-mayhew#11 /vendor/silverstripe/framework/src/Core/Config/CoreConfigFactory.php(67): SilverStripe\Core\Config\CoreConfigFactory->createCore() 
		stevie-mayhew#12 [internal function]: SilverStripe\Core\Config\CoreConfigFactory->SilverStripe\Core\Config\{closure}() 
		stevie-mayhew#13 /vendor/silverstripe/config/src/Collections/CachedConfigCollection.php(139): call_user_func(Object(Closure)) 
		stevie-mayhew#14 /vendor/silverstripe/config/src/Collections/CachedConfigCollection.php(88): SilverStripe\Config\Collections\CachedConfigCollection->getCollection() 
		stevie-mayhew#15 /vendor/silverstripe/framework/src/Core/Config/Config_ForClass.php(81): SilverStripe\Config\Collections\CachedConfigCollection->get('SilverStripe\\Co...', 'module_priority', 1) 
		stevie-mayhew#16 /vendor/silverstripe/framework/src/Core/Config/Config_ForClass.php(114): SilverStripe\Core\Config\Config_ForClass->get('module_priority', 1) 
		stevie-mayhew#17 /vendor/silverstripe/framework/src/Core/Manifest/ModuleManifest.php(232): SilverStripe\Core\Config\Config_ForClass->uninherited('module_priority') 
		stevie-mayhew#18 /vendor/silverstripe/framework/src/Core/BaseKernel.php(200): SilverStripe\Core\Manifest\ModuleManifest->sort() 
		stevie-mayhew#19 /vendor/silverstripe/framework/src/Core/CoreKernel.php(32): SilverStripe\Core\BaseKernel->bootManifests(true) 
		stevie-mayhew#20 /vendor/silverstripe/framework/src/Control/HTTPApplication.php(132): SilverStripe\Core\CoreKernel->boot(true) 
		stevie-mayhew#21 /vendor/silverstripe/framework/src/Control/Middleware/HTTPMiddlewareAware.php(65): SilverStripe\Control\HTTPApplication->SilverStripe\Control\{closure}(Object(SilverStripe\Control\HTTPRequest)) 
		stevie-mayhew#22 /vendor/silverstripe/framework/src/Control/HTTPApplication.php(130): SilverStripe\Control\HTTPApplication->callMiddleware(Object(SilverStripe\Control\HTTPRequest), Object(Closure)) 
		stevie-mayhew#23 /vendor/silverstripe/framework/src/Control/HTTPApplication.php(113): SilverStripe\Control\HTTPApplication->execute(Object(SilverStripe\Control\HTTPRequest), Object(Closure), true) 
		stevie-mayhew#24 /public/index.php(25): SilverStripe\Control\HTTPApplication->handle(Object(SilverStripe\Control\HTTPRequest)) 
		stevie-mayhew#25 {main} thrown in /vendor/marcj/topsort/src/CircularDependencyException.php on line 34
  • Loading branch information
obj63mc authored Jun 28, 2023
1 parent 356f06f commit 2ace80b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion _config/hasoneedit.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
Name: hasoneedit
After: framework/*
After: framework
---
SilverStripe\CMS\Controllers\CMSMain:
extensions:
Expand Down

0 comments on commit 2ace80b

Please sign in to comment.