frontend: Log streaming service recommended maximums #11733
Conversation
prgmitchell
force-pushed
the
logServiceMaximums
branch
3 times, most recently
from
81d15e2 to
fa436f5
Compare
Log the maximum recommended audio and video bitrate when the user ticks the "Ignore streaming service setting recommendations" box.
prgmitchell
force-pushed
the
logServiceMaximums
branch
from
fa436f5 to
49a1380
Compare
|
@PatTheMav updated according to your review comments. FYI I have gotten slightly mixed messages around some of this from comments on the previous PR that was approved but your suggestions all made sense. |
No worries, we're in a transitory phase away from "prior art" and towards "new rules", particularly with the frontend refactor PR merged that aims to establish some of those rules. It'll be a bit like pulling teeth for the foreseeable future to get rid of old habits among contributors. 😅 |
| std::string videoBitRateLogString = maxVideoBitrate > 0 ? std::to_string(maxVideoBitrate) | ||
| : "None"; | ||
| std::string audioBitRateLogString = maxAudioBitrate > 0 ? std::to_string(maxAudioBitrate) | ||
| : "None"; | ||
|
|
||
| blog(LOG_INFO, | ||
| "User is ignoring service bitrate limits.\n" | ||
| "Service Recommendations:\n" | ||
| "\tvideo bitrate: %s\n" | ||
| "\taudio bitrate: %s", | ||
| videoBitRateLogString.c_str(), audioBitRateLogString.c_str()); |
There was a problem hiding this comment.
I wonder a bit if we're not overcomplicating this. We could instead:
blog(LOG_INFO,
"User is ignoring service bitrate limits.\n"
"Service Recommendations:\n"
"\tvideo bitrate: %d\n"
"\taudio bitrate: %d",
maxVideoBitrate, maxAudioBitrate);Or are maxVideoBitrate and maxAudioBitrate not guaranteed to be zero if no value is specified? Is there value in distinguishing 0 from None?
There was a problem hiding this comment.
I had originally done it this way actually but to me it seemed to read a little more awkward/unclear if we were to log a max value as 0 when it is actually meant that there is no max recommended value at all.
There was a problem hiding this comment.
I'm willing to wait a bit for a other opinions. It just jumped out to me at first glance that it seemed like extra work here, and I wasn't sure how much extra clarity it granted. cc @Warchamp7
Description
Log the maximum recommended audio and video bitrate when the user ticks the "Ignore streaming service setting recommendations" box.
Remake of #10917 because I broke something when rebasing and the commit new commit is not showing.
Motivation and Context
Mentioned by @Warchamp7 that we should warn when a user is going above the recommended bitrate in the loganalyzer, this logging is a requirement to make that happen.
How Has This Been Tested?
Tested Twitch and Youtube in both simple and advanced output mode, both showed the correct values.
Tested with "Custom" to confirm it is showing "None" for audio and video bitrate maximums when those values are returning 0.
https://obsproject.com/logs/ZuadI85OgoP0Yjjj
Types of changes
Checklist: