Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batchget 4002 #277

Closed
wants to merge 6 commits into from
Closed

Fix batchget 4002 #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
611ba15
set table name to lower case
maochongxin Jan 7, 2025
32da54e
set query table name to lower case
maochongxin Jan 7, 2025
da8577c
remove unused sleep
maochongxin Jan 7, 2025
8d1a48d
Revert "set query table name to lower case"
maochongxin Jan 7, 2025
bbaf497
fix batch get 4002
maochongxin Jan 8, 2025
1fdfa82
fix log
maochongxin Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...m/alipay/oceanbase/rpc/protocol/payload/impl/execute/query/AbstractQueryStreamResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ protected ObPayload commonExecute(ObTableClient client, Logger logger,
}
} else {
String logMessage = String.format(
"exhaust retry while meet NeedRefresh Exception, table name: %s, ls id: %d, batch ops refresh table, errorCode: %d",
"exhaust retry while meet NeedRefresh Exception, table name: %s, batch ops refresh table, errorCode: %d",
indexTableName,
((ObTableException) e).getErrorCode()
);
Expand Down
1 change: 0 additions & 1 deletion src/main/java/com/alipay/oceanbase/rpc/table/ObTableClientBatchOpsImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,6 @@ private void executeWithRetries(ObTableOperationResult[] results, Map.Entry<Long
throw e;
}
}
Thread.sleep(obTableClient.getRuntimeRetryInterval());
}

if (allPartitionsSuccess) {
Expand Down
11 changes: 9 additions & 2 deletions src/main/java/com/alipay/oceanbase/rpc/table/ObTableClientLSBatchOpsImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,15 @@ public void partitionExecute(ObTableSingleOpResult[] results,
tableLsOp.setLsId(lsId);
tableLsOp.setReturnOneResult(returnOneResult);
tableLsOp.setNeedAllProp(needAllProp);
tableLsOp.setTableName(tableName);
// On the server side, table group names may include uppercase letters,
// but table names are always in lowercase. In certain cases, batch get
// operations depend on the provided table name for matching. Therefore,
// a conversion is performed here to ensure proper matching.
String argTableName = tableName;
if (entityType == ObTableEntityType.HKV && !obTableClient.isTableGroupName(argTableName)) {
argTableName = tableName.toLowerCase();
}
tableLsOp.setTableName(argTableName);
// fetch the following parameters in first entry for routing
long tableId = 0;
long originPartId = 0;
Expand Down Expand Up @@ -702,7 +710,6 @@ private void executeWithRetries(
throw e;
}
}
Thread.sleep(obTableClient.getRuntimeRetryInterval());
}

if (allPartitionsSuccess) {
Expand Down
Loading