Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect isFocusable result for ShadowRoot #155

Conversation

jpzwarte
Copy link
Contributor

Fixes #154

Copy link

netlify bot commented Nov 29, 2023

Deploy Preview for popover-polyfill ready!

Name Link
🔨 Latest commit 9598985
🔍 Latest deploy log https://app.netlify.com/sites/popover-polyfill/deploys/6566ef0ac6dc4300083ec67d
😎 Deploy Preview https://deploy-preview-155--popover-polyfill.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jpzwarte
Copy link
Contributor Author

jpzwarte commented Nov 29, 2023

Please review this carefully as I'm not sure about my fix and I don't know how to test this against my code before it's actually released.

Copy link
Collaborator

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgerigmeyer jgerigmeyer merged commit 079f724 into oddbird:main Nov 29, 2023
6 checks passed
@jpzwarte jpzwarte deleted the fix/delegates-focus-without-focusable-element branch November 29, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_a.focus is not a function with delegatesFocus: true, but no focusable element
3 participants