Update build documentation #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Emilgardis
reviewed
May 11, 2023
| cargo build --release | ||
| ``` | ||
|
|
||
| The executable will be located at `target/release/pyapp.exe` if on Windows or `target/release/pyapp` otherwise. If a particular [target](https://doc.rust-lang.org/cargo/reference/config.html#buildtarget) has been set then the `release` directory will be nested one level deeper under `target/<TARGET>`. |
There was a problem hiding this comment.
This is not correct, when cargo is invoked with --target it unconditionally puts it in target/<triplet/..., and cross will always specify the target even if you call cross build without a specific target.
There was a problem hiding this comment.
On Windows when I run cargo build --release --target x86_64-pc-windows-msvc I get:
There was a problem hiding this comment.
So I should change it to say "if a target has been set or if cross is used"?
There was a problem hiding this comment.
Yes.
You should be getting a warning though if your default on windows is msvc or you try to use msvc, without having a custom image
[cross] warning: `cross` does not provide a Docker image for target x86_64-pc-windows-msvc, specify a custom image in `Cross.toml`.
[cross] note: Falling back to `cargo` on the host.
ofek
added a commit
that referenced
this pull request
May 11, 2023
EnigmaGlimmer
added a commit
to EnigmaGlimmer/Python_app
that referenced
this pull request
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also documented the cross compilation temporary limitation cross-rs/cross#1215