Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🩹 fix data resolution for charts with datasets #430

Merged
merged 1 commit into from
Oct 30, 2023
Merged

🩹 fix data resolution for charts with datasets #430

merged 1 commit into from
Oct 30, 2023

Conversation

krmax44
Copy link
Member

@krmax44 krmax44 commented Oct 23, 2023

By default, Altair exports to Vega like this:

  "data": {
    "name": "data-716699051e44dcc44a893338489d4f65"
  },
  "datasets": {
    "data-716699051e44dcc44a893338489d4f65": [

Currently our implementation fails on resolving the data, as it tries to lookup some element with an id that does not exist (as there is no url or data.values, which is not required though).

@krmax44 krmax44 requested review from stefanw and pajowu October 23, 2023 15:11
@stefanw stefanw force-pushed the krmax44/fix-vega-datasets branch from c5a5fc4 to ce7aec8 Compare October 30, 2023 09:00
@stefanw stefanw enabled auto-merge (rebase) October 30, 2023 09:00
@stefanw stefanw merged commit 46c7594 into main Oct 30, 2023
3 checks passed
@stefanw stefanw deleted the krmax44/fix-vega-datasets branch October 30, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pajowu pajowu pajowu approved these changes

@stefanw stefanw stefanw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krmax44 @stefanw @pajowu