Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Use froide is_crew helper #616

Merged
merged 2 commits into from
Nov 22, 2024
Merged

🐛 Use froide is_crew helper #616

merged 2 commits into from
Nov 22, 2024

Conversation

pajowu
Copy link
Member

@pajowu pajowu commented Nov 19, 2024

Depends on okfde/froide#907

@pajowu pajowu requested review from krmax44 and stefanw November 19, 2024 16:23
@pajowu pajowu force-pushed the pajowu/is_crew_helper branch from da2e097 to 17e6aa2 Compare November 22, 2024 13:44
Copy link
Member

@stefanw stefanw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep the dependency changes out of PRs? They are a hassle to merge. I often just update dependency after PR merge with a commit directly to main 😬 .

@pajowu
Copy link
Member Author

pajowu commented Nov 22, 2024

Since I "rebase and merge" and keep the dependenceis in a seperate commit, it is relatively easy to keep up to date and I wanted to see the tests pass before merging. But for bigger PRs / once that are not directly ready for merging, I agree

@pajowu pajowu merged commit 75b6f20 into main Nov 22, 2024
3 checks passed
@pajowu pajowu deleted the pajowu/is_crew_helper branch November 22, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants