Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantics - Removal of CSS #71

Open
katknow opened this issue Jan 6, 2025 · 1 comment
Open

Semantics - Removal of CSS #71

katknow opened this issue Jan 6, 2025 · 1 comment

Comments

@katknow
Copy link

katknow commented Jan 6, 2025

When removing the CSS from the page, a smaller, non-functional button called "toggle search" appears below the search bar. Additionally, if there is a carousel it loses all functionality.

kimisgold added a commit that referenced this issue Jan 15, 2025
* Add screen reader accessible text label.
* Create aria-hidden span for icon pseudo element.
* Also revises translate plugin calls.
@kimisgold
Copy link
Contributor

Copying my response from the equivalent issue in cozy.

So I think the issue is actually targeting icons and ensuring they have text fallbacks of some kind. Turning off the CSS exposes this better: if the button doesn't have discernible meaning without the icon's presence, it becomes inaccessible. In the commit above, I've included text labels that are mainly exposed to screen readers, and the icons themselves are now in spans that are hidden from screen readers and should not be read out loud.

The search toggle button doesn't have a visible text label when you remove styles. While it did have an aria-label, I opted to give it a text label only viewable to screen readers when CSS is on. Should be ready for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants