Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantics #43

Open
katknow opened this issue Jan 6, 2025 · 1 comment
Open

Semantics #43

katknow opened this issue Jan 6, 2025 · 1 comment

Comments

@katknow
Copy link

katknow commented Jan 6, 2025

Cozy is getting pinged for the same CSS issues as Center Row - omeka-s-themes/centerrow#71
kimisgold added a commit that referenced this issue Jan 10, 2025
@kimisgold
Revise header icon button a11y, hide mmenu. (#43)
1f4009c 
* Put icons into spans with aria-hidden="true" so screen readers won't
  read them.
* Provide tooltips via title attribute.
* Use sr-only spans for text labels.
* Hide mmenu when not open so it doesn't peek behind main content.
@kimisgold
Copy link
Contributor

So I think the issue is actually targeting icons and ensuring they have text fallbacks of some kind. Turning off the CSS exposes this better: if the button doesn't have discernible meaning without the icon's presence, it becomes inaccessible. In the commit above, I've included text labels that are mainly exposed to screen readers, and the icons themselves are now in spans that are hidden from screen readers and should not be read out loud.

@kimisgold kimisgold mentioned this issue Jan 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kimisgold @katknow