Fix cross platform builds by adding a dedicated workflow #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libdf.dll.a for linking and df.dll for runtime were added src.cmake file update to check for platform for linking DeepFilter
|
A few local tests showed some promise, but job times hitting 6+ minutes seems rather inefficient. |
omeryusufyagci
force-pushed
the
55-bug-cross-platform-compilation-support-is-broken-for-core
branch
from
e390d95 to
6009fc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #55, cross platform builds broke with the introduction of the linux .so as a dependency.
This PR introduces a new workflow that will take care of building the shared objects for each supported platform.