Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable agent auto update in snaps #670

Merged

Conversation

matheushent
Copy link
Member

What

This PR removes the configuration task-self-update-interval-seconds from the jobbergate agent snap.

Why

The agent is not supposed to update itself when deployed by the snap.


Peer Review

Please follow the upstream omnivector documentation concerning
peer-review guidelines.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.58%. Comparing base (119bc01) to head (3a84a63).
Report is 1 commits behind head on release/5.4.

Additional details and impacted files
@@             Coverage Diff              @@
##           release/5.4     #670   +/-   ##
============================================
  Coverage        92.58%   92.58%           
============================================
  Files               85       85           
  Lines             4490     4490           
============================================
  Hits              4157     4157           
  Misses             333      333           
Flag Coverage Δ
agent 92.80% <ø> (ø)
api 95.33% <ø> (ø)
cli 88.62% <ø> (ø)
core 96.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matheushent matheushent merged commit bd82566 into release/5.4 Dec 16, 2024
13 checks passed
@matheushent matheushent deleted the matheushent/disable-agent-auto-update-in-snaps branch December 16, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants