src: attr: quantization refactor (part 1)

[dzarukin]

Every year around Christmas time something happens to quantization:

• 2022 - a move to runtime happened, lots of obsolete code left behind
• 2023 - advanced quantization with groups appeared, even more code that could use some love left behind.
• 2023.5 - extension of zero-points for SRC argument happened, zero-points has become a warehouse of variable to access directly.
• 2024 - time for refactor now!

The whole point of this refactor is to move quantization attributes to C++ way of doing things - provide clear and simple interfaces to operate with objects and close members.
This part 1 covers scales which were not that bad in terms of interfaces but could be better with argument members which this part covers.

Interface for both scales and its new underlying object, quant_entry_t, provide getters for a mask, data_type and groups (no need to worry about ndims any longer!), as well as default values checks.
Initialization is still done through set, reset was replaced with set,

Any operations with masks should happen only after verifying that specific arg scale is not default! It's forced now through an invalid mask value which can't be used as is.

Among legacy use-cases here are the main changes across sources:
common:

• some primitive attribute checkers got more checks added.
  cpu:
• many places updated mask != 0 which was the default value for common and non-initialized scales to mask > 0 as now the default mask is negative.
  • A check for equality is still valid while it's highly recommended to avoid unequal comparison (unless you really know what you are doing).
    gpu:
• found some bugs in gemm_with_post_ops implementations.
• changed logic in several generic/cudnn kernels to match the new behavior.
  tests:
• updated gtests to comply with updated primitive checks.

Part 2 will cover zero-points.

Disclaimer: the change is somewhat fundamental, the bug leaks are highly possible even if all tests are passing. Feel free to report any if I missed something.

[dzarukin]

make test

[dzarukin]

make test

[dzarukin]

make test

[mgouicem]

Looks good overall, thanks for the refactor.
Just one thing about the mask: moving from a default of 0 to -1 seems slippery.

Now the dev will have to always check if the value is non default before doing a comparison to 0, or doing some binary operation (e.g. or/xor).
I think it might be worth to normalize the mask upon get_mask so that default value becomes an implementation detail.

[dzarukin]

make test

[dzarukin]

make test

[dzarukin]

make test