Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SLES15 to multi NUMA CI #1038

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add SLES15 to multi NUMA CI #1038

wants to merge 1 commit into from

Conversation

intel12232289
Copy link

@intel12232289 intel12232289 requested a review from a team as a code owner January 14, 2025 13:42
@intel12232289 intel12232289 changed the title Add-SLES15-to-multi-NUMA-CI Add SLES15 to multi NUMA CI Jan 14, 2025
@intel12232289 intel12232289 force-pushed the Add-SLES15-to-multi-NUMA-CI branch from 9eab359 to f726d15 Compare January 15, 2025 08:48
lukaszstolarczuk
lukaszstolarczuk approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I belive it's ready now for merging. Changing this to draft though, as we don't yet have runner enabled - I'll re-enable it (and merge), once the runner is up in this repo.

@lukaszstolarczuk lukaszstolarczuk marked this pull request as draft January 15, 2025 11:22
@intel12232289
Copy link
Author

Should I add this runner now?

PatKamin
PatKamin reviewed Jan 21, 2025
View reviewed changes
.github/workflows/reusable_multi_numa.yml
@@ -19,7 +19,7 @@ jobs:

strategy:
matrix:
os: [ubuntu-22.04, rhel-9.1]
os: [ubuntu-22.04, rhel-9.1, sles-15]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a name containing an SP version of SLES

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatKamin PatKamin PatKamin left review comments

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@intel12232289 @lukaszstolarczuk @PatKamin