Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle GetPrice with decimals #123

Merged
merged 13 commits into from
Dec 31, 2024
Merged

Handle GetPrice with decimals #123

merged 13 commits into from
Dec 31, 2024

Conversation

hieuvubk
Copy link
Collaborator

@hieuvubk hieuvubk commented Dec 26, 2024 •
edited
Loading

  • add decimals to proposals
  • recalculate GetPrice with base, quote decimals
  • price = (baseRate * 10^(quoteDec)) / (quoteRate * 10^(baseDec))

@hieuvubk hieuvubk marked this pull request as draft December 26, 2024 15:25
@DongLieu DongLieu marked this pull request as ready for review December 31, 2024 09:44
@vuong177 vuong177 merged commit fa323a7 into main Dec 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DongLieu DongLieu DongLieu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hieuvubk @DongLieu @vuong177