Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add layout_scrimMode param to hide or show child elements on content … #36

Closed
wants to merge 1 commit into from

Conversation

dmfs
Copy link

@dmfs dmfs commented Apr 6, 2017

…scrim. This is in particular useful to switch from a dark to a light toolbar, as seen in the demo.

…scrim. This is in particular useful to switch from a dark to a light toolbar, as seen in the demo.
@raphaelm
Copy link
Member

raphaelm commented Apr 7, 2017

Hi,

first of all, thank you very much.

If we understood it correctly, this and #37 are both not really related to the multiline functionality that this library provides, but instead a general extension of the collapsing toolbar (in contrast to #34, which is a direct improvement to the collapsing multiline text).

Therefore, we think that it should not be added to our library, as every additional feature also potentially increases the amount of work needed when updating the library to a new Support Library version. You could probably also extend our CollapsingToolbarLayout class (in your project or even as a separate open source library) to implement the same feature.

@dmfs
Copy link
Author

dmfs commented Apr 7, 2017

That's right #36 and #37 are not related to multi-line at all. I don't mind to maintain my changes in my own fork, just wanted to share them with you.

@raphaelm
Copy link
Member

That's right #36 and #37 are not related to multi-line at all. I don't mind to maintain my changes in my own fork, just wanted to share them with you.

Okay. Thank you very much vor that, it's really appreciated, but I think we'd rather keep this one simple here :)

@dmfs dmfs closed this Apr 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants